Cancel state transition when exception is thrown inside observer#184
Open
NelsonFrancisco wants to merge 8 commits intojakesgordon:masterfrom
Open
Cancel state transition when exception is thrown inside observer#184NelsonFrancisco wants to merge 8 commits intojakesgordon:masterfrom
NelsonFrancisco wants to merge 8 commits intojakesgordon:masterfrom
Conversation
If the state was already mutated, the state goes back. If it is a promise, then it catches the promise exception, reverts the state, and throws the error again.
when an error is thrown inside an observer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#171 related
When you throw an exception inside an observer the FSM state might be updated:
This PR makes this consistent, and it always reverts the state.
It basically reverts to the previous state when the exception is thrown IF the current state is different from the previous one, defined in the transition.
Promises supported